[workaround] Alias "PAL-M" to "MPAL" in get_format_parameters#174
Merged
oyvindln merged 1 commit intooyvindln:vhs_decodefrom Dec 8, 2024
Inky1003:patch-1
Merged
[workaround] Alias "PAL-M" to "MPAL" in get_format_parameters#174oyvindln merged 1 commit intooyvindln:vhs_decodefrom Inky1003:patch-1
oyvindln merged 1 commit intooyvindln:vhs_decodefrom
Inky1003:patch-1
Conversation
This fixes PAL-M TBCs not opening in filter_tune tool. For later: decide if PAL-M will be named only either "PAL-M", "MPAL" or "PALM".
Owner
|
Yeah I'm not sure why the code uses MPAL, can probably just change that. I'm not really fond of using a hyphen in the name since it's a symbol that tends to have a meaning in programming and markup languages and thus the name can't map easily to an enum variant so I would maybe prefer PALM or PAL_M to PAL-M. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PAL-M TBCs were not opening in filter_tune tool because .tbc.json file stores "PAL-M", but whatever reason the vhs-decode code calls PAL-M as "MPAL". This aliases "PAL-M" to "MPAL" and makes filter_tune work again.
For later: decide if PAL-M will be named only either "PAL-M", "MPAL" or "PALM".
I suggest calling It "PAL-M" because even though the entire code calls It "MPAL", It's a simple string with no more than 5 characters (in SECAM's case, no more than 8), and nobody calls PAL-M like that. Also, If so, you would need to change the TBC/JSON specifications, and that would break everything.