Skip to content

Switch migration format to unix timestamp#4

Merged
oxtyped merged 1 commit intomainfrom
switch-migration-format
Mar 24, 2023
Merged

Switch migration format to unix timestamp#4
oxtyped merged 1 commit intomainfrom
switch-migration-format

Conversation

@oxtyped
Copy link
Copy Markdown
Owner

@oxtyped oxtyped commented Mar 23, 2023

This PR attempts to fix #3

As armv7 has a 32-bit limit, our current default migration datetime would quickly overflow causing error doing a gpodder2go init.

This fix changes the migration format to a sequential one, starting with 000001.

I had originally preferred to switch to a Unix Timestamp so that we can still keep some time data in the migration filename, but that would still impose a limit of 2147483647 (or Tuesday, January 19, 2038 3:14:07 AM GMT) for 32-bit devices.

Even though I would expect that 32-bit devices should have been phased out by then, it would still be irresponsible to drop support for other users still using this software on older devices then.

Important Notice

For existing users who had previously already migrated with the old timestamp, it is recommended that you force your migration as soon as you can

migrate -path=migrations/ -database sqlite3://${DB} force 000001

@oxtyped
Copy link
Copy Markdown
Owner Author

oxtyped commented Mar 24, 2023

Merging in.

@oxtyped oxtyped merged commit 2d00f3e into main Mar 24, 2023
@oxtyped oxtyped deleted the switch-migration-format branch March 24, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build for armv7

1 participant