Merged
Conversation
Owner
Author
|
Merging in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #3
As armv7 has a 32-bit limit, our current default migration datetime would quickly overflow causing error doing a
gpodder2go init.This fix changes the migration format to a sequential one, starting with
000001.I had originally preferred to switch to a Unix Timestamp so that we can still keep some time data in the migration filename, but that would still impose a limit of
2147483647(or Tuesday, January 19, 2038 3:14:07 AM GMT) for 32-bit devices.Even though I would expect that 32-bit devices should have been phased out by then, it would still be irresponsible to drop support for other users still using this software on older devices then.
Important Notice
For existing users who had previously already migrated with the old timestamp, it is recommended that you force your migration as soon as you can