build: add fmt, lint, vulncheck to improve code readability and security#21
Merged
oxtyped merged 1 commit intooxtyped:mainfrom Mar 31, 2024
zhoukuncheng:main
Merged
build: add fmt, lint, vulncheck to improve code readability and security#21oxtyped merged 1 commit intooxtyped:mainfrom zhoukuncheng:main
oxtyped merged 1 commit intooxtyped:mainfrom
zhoukuncheng:main
Conversation
Owner
|
Thanks for this and the clear PR description! 🙇 I don't have any issues with PR and the tools used in general. Just have one quick question, I noticed that the linter (probably) is removing the explicit returns. I usually purposefully write a return for readability purposes, so this is something quite curious for me. Do you know what might be the rationale behind this removal? |
Contributor
Author
|
I added the golangci-lint command inspired by the miniflux's Makefile. Upon running the linter, I received the following warning: The documentation for the S1023 rule recommends removing redundant return:
|
oxtyped
approved these changes
Mar 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to the gpodder2go project, it is compatible with the AntennaPod and gPodder clients very well. However, I found that the project lacked some code check tools, so I added some check targets to the Makefile and fixed issues scanned by these tools.
The main changes include:
Formatting and Linting: Applied
gofumpt,goimports, andgolangci-lintto ensure consistent code formatting and adherence to best practices.Vulnerability Scanning: Ran
govulncheckto identify and address potential vulnerabilities in the project dependencies.Dependency Updates: Updated the
go.modandgo.sumfiles to include the latest versions of project dependencies, addressing vulnerabilities scanned bygovulncheck.