ci: automatically build & push docker image to ghcr.io#20
Merged
oxtyped merged 2 commits intooxtyped:mainfrom Apr 1, 2024
Merged
ci: automatically build & push docker image to ghcr.io#20oxtyped merged 2 commits intooxtyped:mainfrom
oxtyped merged 2 commits intooxtyped:mainfrom
Conversation
oxtyped
reviewed
Mar 31, 2024
Owner
There was a problem hiding this comment.
Thanks for this! ❤️
I have no issue with this, just that we need to bump up the versions in order for it to work (ref: sigstore/cosign#3614). I've added a comment below.
307a7e2 to
e6ffb9f
Compare
build: mark entrypoint.sh +x
e6ffb9f to
56118c8
Compare
Contributor
Author
|
I rebased the branch onto main and changed the versions to only limit to major (breaking) versions. Since the recent go requirement bump I also changed the Dockerfile to use latest golang and alpine images. Also keep in mind that until the next version bump for gpodder2go only the :main image will be build. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @TheBlueSky mentioned in #17 it would be nice to have automatic docker builds.
GitHub Actions provides this for free.
This action builds and pushes the image to ghcr.io, directly linked to the github repository.
The resulting image will be
ghcr.io/oxtyped/gpodder2go.Releases are labeled with :latest and :main is the main branch (latest commit)
Have a look at https://github.com/tippfehlr/gpodder2go in the sidebar, the ci ran in my fork and built an image