-
-
Notifications
You must be signed in to change notification settings - Fork 284
Install dotenv-linter deterministically #6385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…egalinter into dotenv-linter-deterministic
|
/build
|
✅
|
| # | ||
| # dotenv-linter installation | ||
| && wget -q -O - https://raw.githubusercontent.com/dotenv-linter/dotenv-linter/master/install.sh | sh -s | ||
| && wget -q -O - https://raw.githubusercontent.com/dotenv-linter/dotenv-linter/master/install.sh | sh -s -- -b /usr/local/bin "v${DOTENV_LINTER_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Dotenv-Linter Installation Script Versioning Issue
The dotenv-linter installation fetches its install.sh script from the master branch, which can lead to non-deterministic builds. Although a DOTENV_LINTER_VERSION is defined, it's not used to specify the script's version in the download URL.
Additional Locations (17)
flavors/go/Dockerfile#L406-L407flavors/javascript/Dockerfile#L469-L470flavors/dotnetweb/Dockerfile#L545-L546flavors/salesforce/Dockerfile#L420-L421flavors/cupcake/Dockerfile#L657-L658flavors/python/Dockerfile#L441-L442linters/env_dotenv_linter/Dockerfile#L151-L152flavors/swift/Dockerfile#L396-L397flavors/dotnet/Dockerfile#L475-L476flavors/ci_light/Dockerfile#L258-L259flavors/rust/Dockerfile#L393-L394flavors/c_cpp/Dockerfile#L403-L404Dockerfile#L887-L888flavors/terraform/Dockerfile#L417-L418flavors/php/Dockerfile#L428-L429flavors/ruby/Dockerfile#L416-L417flavors/java/Dockerfile#L464-L465
echoix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ignoring the comment of cursor that seems to suggest to try to fetch the install script from a branch too, but I would be surprised it would become incompatible

Proposed Changes
Install dotenv-linter deterministically because they hadn't released anything in two years and it had to be installed from the master branch: dotenv-linter/dotenv-linter#837
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance