mega-linter-runner: Improve check if running as script or module#3233
Merged
echoix merged 2 commits intooxsecurity:mainfrom Dec 28, 2023
Merged
mega-linter-runner: Improve check if running as script or module#3233echoix merged 2 commits intooxsecurity:mainfrom
echoix merged 2 commits intooxsecurity:mainfrom
Conversation
Collaborator
Author
|
Since the mega-linter-runner tests at the end of the build and deploy dev workflow doesn’t have to waste time pulling, the time is down to 2min22 seconds for this step, instead of the 6min30 sec that was taken. In the tests, it’s the v8r linter that seems way too slow (40 secs instead of less than 2 for the other 2 linters) |
4 tasks
nvuillam
approved these changes
Dec 28, 2023
Member
nvuillam
left a comment
There was a problem hiding this comment.
Seems ok :)
Please test with mega-linter-runner@beta before our next release :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the check for using the command line arguments to create the MegaLinterRunnerCli() when run as a script wasn’t working correctly since changed to use modules, at least in tests. That meant that all command line arguments (of the test invocation) were passed when the tests for modules was used (since called before), and since the no docker pull option isn’t in the argv of the mocha invocation, it pulled the latest Megalinter docker image (a second one) and started to lint the workspace instead of just doing the tests.
Here, the argv is really only passed when it is called a script and not a module.
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance