Make WrapperVisitor even more unholy but somehow better#195
Merged
sunshowers merged 5 commits intoAug 8, 2024
Merged
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
Jul 24, 2024
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Contributor
Author
|
BTW I've just used an empty slice as a sentinel value. Since we can never really have bytes in this situation, we can pass in arbitrary commands this way. Neat. |
sunshowers
commented
Jul 25, 2024
ahl
approved these changes
Aug 8, 2024
ahl
left a comment
Collaborator
There was a problem hiding this comment.
looks good; couple of comment suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered while trying to use
ParseWrapperthat we were losing spaninformation, due to the serialize/deserialize roundtrip. Here's this
alternative "solution" that addresses this using a thread-local.
Test included, and also checked that it works great in Dropshot.