Skip to content

[propolis] make InstanceSerialConsoleHelper::recv cancel-safe#438

Closed
sunshowers wants to merge 2 commits into
masterfrom
sunshowers/spr/propolis-make-instanceserialconsolehelperrecv-cancel-safe
Closed

[propolis] make InstanceSerialConsoleHelper::recv cancel-safe#438
sunshowers wants to merge 2 commits into
masterfrom
sunshowers/spr/propolis-make-instanceserialconsolehelperrecv-cancel-safe

Conversation

@sunshowers

@sunshowers sunshowers commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Alternative to #435.

Created using spr 1.3.4
Created using spr 1.3.4
@sunshowers sunshowers marked this pull request as draft June 15, 2023 21:40
@sunshowers

Copy link
Copy Markdown
Contributor Author

This is incorrect because as pointed out on #435, we need to not send characters on the old ws_stream once migration has started.

@sunshowers

Copy link
Copy Markdown
Contributor Author

Per a discussion with @lifning, abandoning this in favor of #435. That's for two reasons:

  1. We need to not send characters on the old ws_stream once migration is complete, and this gets us farther away from that goal, not closer to it.
  2. By the time we receive a migration message, the migration has already completed, so the remaining part (cancel-unsafe) is relatively quick.

@sunshowers sunshowers closed this Jun 15, 2023
@sunshowers sunshowers deleted the sunshowers/spr/propolis-make-instanceserialconsolehelperrecv-cancel-safe branch June 19, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant