This is a small followup from oxidecomputer/omicron#3356. I think InstanceSerialConsoleHelper::recv() is not cancel safe: it could pull a value from its ws_stream; if it is then cancelled at a later .await point, that value will be lost. This method is used in a select! arm in propolis-cli, and could trigger cancel-unsafety issues there.
This is a small followup from oxidecomputer/omicron#3356. I think
InstanceSerialConsoleHelper::recv()is not cancel safe: it could pull a value from itsws_stream; if it is then cancelled at a later.awaitpoint, that value will be lost. This method is used in a select! arm in propolis-cli, and could trigger cancel-unsafety issues there.