default bgp max_paths to 1 when db value is null#9863
Closed
rcgoodfellow wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
The issue is deeper than this. We are failing before we even get here, because we cannot read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We hit an issue on dogfood where the bootstore has an empty BGP config, but peers are configured. There was previously a BGP config on this rack, and it appears it was removed from the bootstore during an online upgrade to the release 18 candidate. After looking through the code I noticed this logic
omicron/nexus/src/app/background/tasks/sync_switch_configuration.rs
Lines 1105 to 1113 in 4a456c9
in combination with this db update
omicron/schema/crdb/bgp-unnumbered-peers/up07.sql
Lines 1 to 4 in 4a456c9
I believe this will result in null values for the
max_pathscolumn for existing rows in thebgp_configtable invalidating the assumptions in the code above.This PR fixes this situation by defaulting a null
max_pathsvalue to one, which as the implicit behavior before this explicit config parameter was introduced.