Initial schema updates disallowing default IP Pool for the internal silo#8964
Merged
Conversation
bnaecker
commented
Aug 30, 2025
Collaborator
- Add database constraints that ensure that we can't set a default pool for the Oxide internal silo. Add tests for this specifically.
- This is part of Enforce relationship between IP Pools reserved for Oxide services silo #8948, but does not resolve it.
ce147e2 to
afb56f3
Compare
- Add database constraints that ensure that we can't set a default pool for the Oxide internal silo. Add tests for this specifically. - This is part of #8948, but does not resolve it.
afb56f3 to
9f49f97
Compare
Collaborator
Author
|
This is a small step towards #8945. To date, we've assumed that our internal silo has exactly 1 IP Pool. That's special, created at rack initialization, linked to the silo, and not operator-modifiable. We can't do that in the long run. For one thing, we need IPv6 IP Pools, but we also want to allow operators to delegate pretty much any IP Pool to the internal silo. That will eventually be used to determine which networks our services need addresses on. The first step, implemented here, is just disallowing a default IP Pool for the internal silo, enforced as a check constraint in the database. |
smklein
reviewed
Sep 2, 2025
david-crespo
reviewed
Sep 2, 2025
Keep endpoint non-idempotent, and catch check violations explicitly
smklein
reviewed
Sep 2, 2025
smklein
reviewed
Sep 2, 2025
Collaborator
Author
|
I’m not finished with the updates from your feedback yet. I’ll re-request review when it is ready.
|
smklein
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.