Skip to content

[sled-agent] Remove chicken switch and always destroy orphaned Omicron datasets#8895

Merged
jgallagher merged 11 commits into
mainfrom
john/sled-agent-always-destroy-orphans
Aug 26, 2025
Merged

[sled-agent] Remove chicken switch and always destroy orphaned Omicron datasets#8895
jgallagher merged 11 commits into
mainfrom
john/sled-agent-always-destroy-orphans

Conversation

@jgallagher

@jgallagher jgallagher commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

The main point of this PR is that the sled-agent config reconciler now always attempts to destroy datasets it believes have been expunged instead of defaulting to reporting them unless an operator has toggled a chicken switch. (See the comments on datasets_destroy_orphans() for details; this is pretty specific to only destroy datasets whose names we understand.) We wanted to ship "report only" in R16 and then confirm during upgrades that this wasn't showing any surprises; now that R16 is out the door we can turn this on all the time.

This also (starts to? attempts to?) removes the sled-agent API endpoints for interacting with the chicken switches. The openapi xtask yelled at me for this, so instead I followed the guide for removing endpoints. This was almost entirely painless, except that I'd already (locally) committed the change to remove the endpoints mixed in with other things, so I had to dig back out the endpoints and the types they used. Kudos to all involved for the tooling and instructions here!

Closes #6177. Closes #7312 (no longer needed). Closes #7313.

Edit: The diff stat here is laughably misleading; the API change means we have to check another full copy of the sled-agent API document, which is ~8000 lines. The changes here are a couple hundred lines.

@andrewjstone andrewjstone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread sled-agent/src/http_entrypoints.rs Outdated
Comment thread sled-agent/src/http_entrypoints.rs Outdated
@jgallagher jgallagher merged commit 33d4f82 into main Aug 26, 2025
16 checks passed
@jgallagher jgallagher deleted the john/sled-agent-always-destroy-orphans branch August 26, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants