[reconfigurator-cli] Populate simulated caboose and test RoT update#8835
Conversation
| name: board.clone(), | ||
| version: version.to_string(), | ||
| sign: None, | ||
| sign: Some(board), |
There was a problem hiding this comment.
Tufaceous uses the board name as the sign for the artifact's cabooses
We can do the same here
jgallagher
left a comment
There was a problem hiding this comment.
I think it's fine to land this before the host OS planner stuff; that's going to be a little while longer before it's ready. If you change the inputs to use latest instead of raw UUIDs, fixing up the merge conflicts shouldn't be too bad.
|
|
||
| # First step: upgrade one SP. | ||
| # First step: upgrade one RoT. | ||
| blueprint-plan dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 f45ba181-4b56-42cc-a762-874d90184a43 |
There was a problem hiding this comment.
I realized this way too late when I was working in this file, but: you can change all of the blueprint-plan lines to
| blueprint-plan dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 f45ba181-4b56-42cc-a762-874d90184a43 | |
| blueprint-plan latest latest |
(for "base of the latest blueprint" and "use the latest collection") to avoid having to manually shuffle all these UUIDs around when we make changes.
| # First step: upgrade one SP. | ||
| # First step: upgrade one RoT. | ||
| blueprint-plan dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 f45ba181-4b56-42cc-a762-874d90184a43 | ||
| blueprint-diff dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1 |
There was a problem hiding this comment.
Similarly, all of these can be just
| blueprint-diff dbcbd3d6-41ff-48ae-ac0b-1becc9b2fd21 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1 | |
| blueprint-diff latest |
for "diff the latest blueprint against its parent".
|
I've merged #8664. So, I'll update this PR to include RoT bootloader tests as well. I can't merge this PR as is because once the cabooses have a |
|
EDIT: #8631 was merged 😄 |
karencfv
left a comment
There was a problem hiding this comment.
I've updated the PR to include testing RoT bootloader as well. Would appreciate another look!
|
Will merge as it had merge conflicts a couple of times now and tomorrow is Saturday for me. It's only tests so we can adjust these if necessary. |
This turned out to be way easier than I anticipated. @jgallagher I know this clashes with your host OS planner PR, happy to hold off merging this until you merge your PR if you prefer 😄
Related: #8798