Skip to content

Testing use of install script in github action#870

Merged
smklein merged 32 commits into
mainfrom
github-test-install-script
May 4, 2022
Merged

Testing use of install script in github action#870
smklein merged 32 commits into
mainfrom
github-test-install-script

Conversation

@smklein

@smklein smklein commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@smklein smklein changed the title Testing use of in github action Testing use of install script in github action Apr 4, 2022
@smklein

smklein commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator Author

Currently, the buildomat brand installation is failing - this is due to the buildomat runner using a too-old Helios image.

At the moment, this failure is expected.

@smklein

smklein commented Apr 4, 2022

Copy link
Copy Markdown
Collaborator Author

Looks like (one version) of the install script is reliably working on all our builders. FYI @davepacheco .

@davepacheco

Copy link
Copy Markdown
Collaborator

Cool -- but how do we know, if it was working before without running the script? (I know it's right for Clickhouse and Cockroach because we removed the special handling but what about the other packages?)

@jclulow

jclulow commented Apr 5, 2022

Copy link
Copy Markdown
Collaborator

Cool -- but how do we know, if it was working before without running the script? (I know it's right for Clickhouse and Cockroach because we removed the special handling but what about the other packages?)

It seems like we would need to produce a different CI environment -- one with the bare minimum packages -- and you'd need to install them with the script each time. I'm not sure if that's worth doing?

Base automatically changed from check-paths-too to main April 8, 2022 15:12
#: name = "helios / build-and-test"
#: variety = "basic"
#: target = "helios"
#: target = "helios-20220502"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Pretty sure this is borked because this value is wrong, but the packages aren't found on the default "helios" value. Need to figure out where these are coming from.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to "helios-latest", looks like that's working.

@smklein smklein marked this pull request as ready for review May 4, 2022 14:59

@david-crespo david-crespo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good!

@smklein smklein merged commit 73c08c8 into main May 4, 2022
@smklein smklein deleted the github-test-install-script branch May 4, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants