[35/n] [reconfigurator] add add_zones_with_mupdate_override chicken switch#8648
Merged
sunshowers merged 8 commits intoJul 23, 2025
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
commented
Jul 22, 2025
|
|
||
| #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, JsonSchema)] | ||
| pub struct ReconfiguratorChickenSwitches { | ||
| pub struct ReconfiguratorChickenSwitchesView { |
Contributor
Author
There was a problem hiding this comment.
Turned the current ReconfiguratorChickenSwitches into a view type, and made both the view and the param types carry around a common ReconfiguratorChickenSwitches struct.
Contributor
There was a problem hiding this comment.
Good idea! I like this a lot.
andrewjstone
approved these changes
Jul 23, 2025
andrewjstone
left a comment
Contributor
There was a problem hiding this comment.
Looks great! I like the way you dealt with keeping the existing options set in omdb.
|
|
||
| #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, JsonSchema)] | ||
| pub struct ReconfiguratorChickenSwitches { | ||
| pub struct ReconfiguratorChickenSwitchesView { |
Contributor
There was a problem hiding this comment.
Good idea! I like this a lot.
|
|
||
| > set chicken-switches --add-zones-with-mupdate-override true | ||
| chicken switches updated: | ||
| * add zones with mupdate override: false -> true |
Created using spr 1.3.6-beta.1
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a chicken switch to enable testing mupdate/update logic for r16 while not affecting customer systems.
Required a few changes but should hopefully be relatively easy to understand. As part of this, added:
TODO: