Skip to content

More manual pagination#7763

Open
smklein wants to merge 2 commits into
paginated-manuallyfrom
more-manual-pagination
Open

More manual pagination#7763
smklein wants to merge 2 commits into
paginated-manuallyfrom
more-manual-pagination

Conversation

@smklein

@smklein smklein commented Mar 7, 2025

Copy link
Copy Markdown
Collaborator

Continuing #7717

@davepacheco

Copy link
Copy Markdown
Collaborator

Did you plan to land this change or is this more of an experiment to see if we could get rid of paginated_multicolumn? FWIW #7717 makes sense to me because we didn't have a way to do that and I agree that expanding this family of functions sounds...awful. I'm less sure it's worth getting rid of paginated_multicolumn given that we have it.

@smklein

smklein commented Mar 8, 2025

Copy link
Copy Markdown
Collaborator Author

Did you plan to land this change or is this more of an experiment to see if we could get rid of paginated_multicolumn? FWIW #7717 makes sense to me because we didn't have a way to do that and I agree that expanding this family of functions sounds...awful. I'm less sure it's worth getting rid of paginated_multicolumn given that we have it.

It's a little bit of both - I wanted to see what this change would look like more broadly, and also wanted to measure at some point to see the impact on compile time, since paginated_multicolumn has fairly complex trait bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants