You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Did you plan to land this change or is this more of an experiment to see if we could get rid of paginated_multicolumn? FWIW #7717 makes sense to me because we didn't have a way to do that and I agree that expanding this family of functions sounds...awful. I'm less sure it's worth getting rid of paginated_multicolumn given that we have it.
Did you plan to land this change or is this more of an experiment to see if we could get rid of paginated_multicolumn? FWIW #7717 makes sense to me because we didn't have a way to do that and I agree that expanding this family of functions sounds...awful. I'm less sure it's worth getting rid of paginated_multicolumn given that we have it.
It's a little bit of both - I wanted to see what this change would look like more broadly, and also wanted to measure at some point to see the impact on compile time, since paginated_multicolumn has fairly complex trait bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing #7717