[reconfigurator] Add dataset disposition to blueprint diffs#7497
Merged
Conversation
jgallagher
commented
Feb 6, 2025
Comment on lines
+75
to
+78
| * oxp_41eaf63b-4fa9-443e-8da1-78d1e79aac7d/crypt/clickhouse_keeper 04cdeda2-c4f7-4f76-bfbf-f946dcdefda3 - in service none none off | ||
| └─ + expunged | ||
| * oxp_41eaf63b-4fa9-443e-8da1-78d1e79aac7d/crypt/zone/oxz_clickhouse_keeper_14b84b08-598b-4756-99ec-eea98f8fa46e 1b4c5dcd-24e9-4076-9219-e9559ae49857 - in service none none off | ||
| └─ + expunged |
Contributor
Author
There was a problem hiding this comment.
This is an example of #7302: the diff said these datasets changed, but because we weren't emitting the dispositions, there were no details about what changed.
andrewjstone
approved these changes
Feb 6, 2025
andrewjstone
left a comment
Contributor
There was a problem hiding this comment.
Ship it! Thanks @jgallagher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7302, I think! (The issue is titled generically, but the specifics are about dataset diffs, which are fixed by this PR.)
The diff is large because of expectorate. The code changes are heavily modified after our existing
ModifiedZone/ zone error stuff (largely "copy, paste, s/zone/dataset/").