[clickhouse] Internal monitoring endpoint#7114
Merged
Merged
Conversation
Contributor
Author
|
Have been playing around with this. I think we can get some sort of Ok looking charts with this data: 
|
andrewjstone
approved these changes
Nov 25, 2024
| rqctx: RequestContext<Self::Context>, | ||
| ) -> Result<HttpResponseUpdatedNoContent, HttpError>; | ||
|
|
||
| /// Retrieve time series from the system database. The value the average of all |
Contributor
There was a problem hiding this comment.
The second sentence appears to be typo'd. Not sure what you are trying to say.
Also, I'd move that sentence after a blank line, so that the doc comments have a short first line. Same for the method above.
Contributor
Author
There was a problem hiding this comment.
lol, idk what was happening there 😄
| let log = self.log.clone().unwrap(); | ||
| let query = settings.query_avg(); | ||
|
|
||
| info!(&log, "Querying system database"; "query" => &query); |
Contributor
There was a problem hiding this comment.
Does this need to be an info log? What about a debug or trace log instead?
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This commit adds an endpoint to retrieve timeseries from the
systemdatabase. For the time being we will only add support for themetric_logandasynchronous_metric_logtables.This endpoint is still a bit bare bones, but will be a good start to begin monitoring the ClickHouse servers.
Examples
Queries per second
Disk usage
Related: #6953