be precise in git dependency specification#6756
Merged
Merged
Conversation
iliana
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #6585 i'd unintentionally removed the fragment from
bhyve_api's source entry in Cargo.lock. it's not wrong, since it's still specifying the desired11371b0..., but without the fragment at the end of the source Cargo parses this as a non-precise reference and updates the git repo tracking this dependency every time it resolves dependdencies. so, put the fragment back and be very clear to Cargo that once it has11371b0...it does not need to do more git operations to try getting a newer version of the commit.(this makes a bit more sense if you imagine source urls like
git+https://github.com/foo.git?rev=main#1234: in the case whererevis a commit it's arguably a bug to fetch from remotes when you already have the commit..)Cargo generally handles this automatically, compare with other version bumps. i suspect i got the lockfile in this state by resolving a merge conflict incorrectly.