[nexus] Separate action to chain instance-updates#6630
Merged
Conversation
Currently, the `instance-update` saga's `siu_commit_instance_updates` saga attempts to check if an additional update saga is needed and start one if so. This is done in the same action that writes back the updated instance record. In [this comment][1] on PR #6503, @davepacheco pointed out that conflating these two operations makes the idempotency tests for the update saga less effective, since the action performs multiple operations (even if some of them are permitted to fail). This commit refactors the instance-update saga so that the chaining operation is performed in a separate action from the rest of the saga. There should be no functional change to the saga's behavior as a result of this, beyond making the idempotency tests more correct. [1]: #6503 (comment)
This was referenced Sep 21, 2024
Member
Author
|
|
gjcolombo
approved these changes
Sep 23, 2024
Co-authored-by: Greg Colombo <greg@oxidecomputer.com>
; Conflicts: ; nexus/src/app/sagas/instance_update/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
instance-updatesaga'ssiu_commit_instance_updatessaga attempts to check if an additional update saga is needed and start one if so. This is done in the same action that writes back the updated instance record. In this comment on PR #6503, @davepacheco pointed out that conflating these two operations makes the idempotency tests for the update saga less effective, since the action performs multiple operations (even if some of them are permitted to fail). This commit refactors the instance-update saga so that the chaining operation is performed in a separate action from the rest of the saga.There should be no functional change to the saga's behavior as a result of this, beyond making the idempotency tests more correct.