[nexus][db] Return 503 when insufficient datasets exist for disk creation#660
Merged
Conversation
… for disk creation Fixes #659
david-crespo
approved these changes
Jan 31, 2022
davepacheco
reviewed
Jan 31, 2022
davepacheco
left a comment
Collaborator
There was a problem hiding this comment.
There's a disk integration test that I mentioned in #661 that I expect has to be updated for this (regardless of which change lands first).
| .map_err(|e| match e { | ||
| TxnError::CustomError( | ||
| RegionAllocateError::NotEnoughDatasets(_), | ||
| ) => Error::unavail("Not enough datasets to allocate disks"), |
Collaborator
There was a problem hiding this comment.
It'd be nice to preserve e's error message here so that we have as much detail as possible in the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #659