[common] Move policy constants to their own module#6340
Merged
Conversation
These constants really don't belong in `address.rs` as they are only tangentially related to addresses. Also add policy for replicated clickhouse. This will be used in a follow up PR. Fixes #6299
davepacheco
reviewed
Aug 15, 2024
davepacheco
left a comment
Collaborator
There was a problem hiding this comment.
I like this! Just found a few typos -- otherwise it's good.
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| //! Feet policy related functionality used by both Reconfigurator and RSS. |
Collaborator
There was a problem hiding this comment.
Suggested change
| //! Feet policy related functionality used by both Reconfigurator and RSS. | |
| //! Fleet policy related functionality used by both Reconfigurator and RSS. |
| // when Nexus provisions Clickhouse. | ||
| // TODO(https://github.com/oxidecomputer/omicron/issues/4000): Set to 2 once we enable replicated ClickHouse | ||
| // TODO(https://github.com/oxidecomputer/omicron/issues/4000): Use | ||
| // omicron_common::policy::CLICKHOUSE_SERVER_REDUNANCY once we enable |
Collaborator
There was a problem hiding this comment.
Suggested change
| // omicron_common::policy::CLICKHOUSE_SERVER_REDUNANCY once we enable | |
| // omicron_common::policy::CLICKHOUSE_SERVER_REDUNDANCY once we enable |
| // when Nexus provisions Clickhouse keeper. | ||
| // TODO(https://github.com/oxidecomputer/omicron/issues/4000): Set to 3 once we enable replicated ClickHouse | ||
| // TODO(https://github.com/oxidecomputer/omicron/issues/4000): Use | ||
| // omicron_common::policy::CLICKHOUSE_KEEPER_REDUDNANCY once we enable |
Collaborator
There was a problem hiding this comment.
Suggested change
| // omicron_common::policy::CLICKHOUSE_KEEPER_REDUDNANCY once we enable | |
| // omicron_common::policy::CLICKHOUSE_KEEPER_REDUNDANCY once we enable |
davepacheco
approved these changes
Aug 15, 2024
Contributor
|
feet policy lol |
Contributor
Author
Lol. Just about to conk out for the night and noticed this. Off to dream about the American foot liberties union |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These constants really don't belong in
address.rsas they are only tangentially related to addresses.Also add policy for replicated clickhouse. This will be used in a follow up PR.
Fixes #6299