[sled-agent] Remove non self-assembling zone code#6162
Merged
Conversation
karencfv
commented
Jul 26, 2024
Comment on lines
-336
to
-344
| impl crate::smf_helper::Service for OmicronZoneType { | ||
| fn service_name(&self) -> String { | ||
| self.kind().service_prefix().to_owned() | ||
| } | ||
| fn smf_name(&self) -> String { | ||
| format!("svc:/oxide/{}", self.service_name()) | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removing this altogether as Omicron zones should not be meddling with smf properties. Only the switch zone still has to unfortunately.
19 tasks
smklein
approved these changes
Jul 26, 2024
Comment on lines
-1510
to
-1513
| // TODO(https://github.com/oxidecomputer/omicron/issues/1898): | ||
| // | ||
| // These zones are self-assembling -- after they boot, there should | ||
| // be no "zlogin" necessary to initialize. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes all code that is no longer necessary now that the self assembling zone work is finished.
Additionally, the
smf_helpermodule has been moved toillumos_utilswhere all the Illumos helper code lives.Closes: #1898