[nexus] Decommission disks in reconfigurator, clean their DB state#6059
Merged
Conversation
jmpesp
reviewed
Jul 18, 2024
jmpesp
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following step to the reconfigurator's execution step: For all disks that are marked expunged, mark them decommissioned. This notably happens after the
deploy_disksstep of execution.This PR also adds a background task that looks for all disks that are decommissioned, but have zpools. It deletes these zpools (and their datasets) as long as no regions nor region snapshots are referencing the contained datasets.
Fixes #6051