@smklein I'm concerned about datasets that should have an* associated IP and port but don't: they can be deleted or not included during creation. How do you feel about a constraint that says those fields have to be non-null based on the kind field?

@smklein I'm concerned about datasets that should have an* associated IP and port but don't: they can be deleted or not included during creation. How do you feel about a constraint that says those fields have to be non-null based on the kind field?

I'm willing to do this -- especially for Crucible -- but if you look at all the spots where I updated "accessing the IP/port columns to cope with being Optional", you might have noticed: it's only Crucible that's accessing the IP/port pair from the dataset record.

This doesn't mean that other services (Cockroach, Clickhouse, etc) don't care about the IP / port values, I think they're just accessing them from a different spot:

And, when we want to look up these values, we look them up via DNS (or at least, we're trying to trend in that direction).

Regardless, patched this in 5122118