Skip to content

[nexus] Add Physical Disk Policy, State#5335

Merged
smklein merged 93 commits into
mainfrom
disk-state-policy
Mar 29, 2024
Merged

[nexus] Add Physical Disk Policy, State#5335
smklein merged 93 commits into
mainfrom
disk-state-policy

Conversation

@smklein

@smklein smklein commented Mar 26, 2024

Copy link
Copy Markdown
Collaborator
  • Adds physical disk state, policy as defined in RFD 457
  • Does not expose any way to modify this information
  • In the future, these values will toggled by both sled expungement, and explicitly through a physical disk API

Fixes #5153

smklein added 30 commits February 23, 2024 16:57
@smklein
[sled-agent] Plumb physical disk info through inventory
a0e89db
@smklein
Plumb disks into inventory
b962606
@smklein
Schema
f3bfadd
@smklein
Fix tests
228bcdf
@smklein
You can't run memetendo swatch games on your macrohard box
0d93a86
@smklein
Primary key order matters
7be0e1e
@smklein
stop ignoring test, it's only flaky locally
470be89
@smklein
Merge branch 'main' into disk-in-inventory
50d4415
@smklein
John's feedback
ad6bf23
@smklein
Slot plumbing
72ac9b5
@smklein
Use slots for synthetic disks
58e3e03
@smklein
fmt
cdab967
@smklein
Fix illumos tests
6d0dc3e
@smklein
Fix test_complex
1d1f2c3
@smklein
Not using new service plan yet
8cad2c5
@smklein
Merge branch 'main' into disk-in-inventory
6f97ab2
@smklein
Zpools in inventory
8983eaa
@smklein
Merge branch 'main' into disk-in-inventory
296ed1e
@smklein
Merge branch 'disk-in-inventory' into zpool-in-inventory
e034542
@smklein
Build background task to periodically update zpools with inventory info
63d3c4a
@smklein
Working through FULL SCANs
4d6d4dc
@smklein
Fix full table scan, add test
8a0dc14
@smklein
Merge branch 'main' into disk-in-inventory
9acc543
@smklein
Merge branch 'disk-in-inventory' into zpool-in-inventory
966109e
@smklein
Sled API for managing disks explicitly
19a8685
@smklein
automated tests
8882145
@smklein
Cope with ledger-less systems
446a2bf
@smklein
fix merge of slots, fmt
0890e75
@smklein
Merge branch 'main' into zpool-in-inventory
f316c5c
@smklein
review feedback
1cd159e
jmpesp
jmpesp approved these changes Mar 27, 2024
View reviewed changes

@jmpesp jmpesp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread schema/crdb/dbinit.sql Outdated
jmpesp
jmpesp reviewed Mar 27, 2024
View reviewed changes
Comment thread schema/crdb/physical-disk-state-and-policy/up03.sql Outdated
@smklein smklein marked this pull request as ready for review March 27, 2024 18:48
@smklein

smklein commented Mar 27, 2024

Copy link
Copy Markdown
Collaborator Author

As an FYI, I added f3e85c5 , which addresses the review comments, but also:

  • Checks for state / policy during region allocation
  • Adds a test that only the "active / in-service" disks are used for region allocation

@smklein smklein mentioned this pull request Mar 29, 2024
Merged
Base automatically changed from sled-agent-api-to-manage-phys-disks to main March 29, 2024 02:40
@smklein smklein enabled auto-merge (squash) March 29, 2024 02:41
@smklein smklein merged commit e762510 into main Mar 29, 2024
@smklein smklein deleted the disk-state-policy branch March 29, 2024 04:05
@smklein smklein mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmpesp jmpesp jmpesp approved these changes

Assignees

@smklein smklein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add notion of physical disk "policy" and "state" to physical disks in the control plane

3 participants

@smklein @jmpesp @andrewjstone