Prune inv_zpool when pruning collections#5301
Merged
Merged
Conversation
smklein
approved these changes
Mar 21, 2024
smklein
left a comment
Collaborator
There was a problem hiding this comment.
Oof, thank you for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this while investigating #5299; I am unsure whether this will actually resolve #5299 though.
I made this same mistake the first time I added something new to inventory; @davepacheco and I discussed the issues with trying to test for this at #4496 (comment). I'm not sure anything has materially changed there, but maybe testing this warrants a closer look.