[nexus] remove services queries & OMDB commands#5044
Conversation
after a bunch of messing with it i made the executive decision to just get rid of that test. the test for DNS propagation exercises it, and it's harder to test now
This reverts commit 9a3f15d.
Depends on #5033. As described in #4947, we would like to remove the `services` table, as its only remaining use is DNS propagation. PR #5033 changes DNS propagation to no longer use the `services` table. Now that we're no longer consuming this table, this commit removes the one method which queries that table (`Datastore::services_list_kind`) and its two remaining callers, the OMDB commands that query the table. I've also removed the test for inserting and querying this table. Note that I have *not* yet removed the code in RSS that actually populates this table when the rack is set up. I thought it might be desirable to still populate this data in case we have to roll back to a previous version of Nexus that uses the `services` table. If this isn't something we care about, I can remove that code as well, allowing us to remove the `Datastore` methods for inserting to `services`.
smklein
left a comment
There was a problem hiding this comment.
LGTM, though the github checks look like real failures to me. I think this is just an EXPECTORATE test failing within the omdb test suite -- try running the following locally to fix:
EXPECTORATE=overwrite cargo nt -p omicron-omdb
I'm okay with doing this incrementally! |
I ran into two other places that are consuming this table.
Before we stop populating the |
|
Closing this in favor of #5287 |
Depends on #5033.
As described in #4947, we would like to remove the
servicestable, as its only remaining use is DNS propagation. PR #5033 changes DNS propagation to no longer use theservicestable. Now that we're no longer consuming this table, this commit removes the one method which queries that table (Datastore::services_list_kind) and its two remaining callers, the OMDB commands that query the table. I've also removed the test for inserting and querying this table.Note that I have not yet removed the code in RSS that actually populates this table when the rack is set up. I thought it might be desirable to still populate this data in case we have to roll back to a previous version of Nexus that uses the
servicestable. If this isn't something we care about, I can remove that code as well, allowing us to remove theDatastoremethods for inserting toservices.