flesh out authz policy#405
Merged
Merged
Conversation
GET /organizations
Collaborator
Author
|
For anybody interested: I'll do an interactive review / walk-through on Monday 11/22 at 10am PT. Let me know and I'll add you to the invite. We'll also record it. |
david-crespo
approved these changes
Nov 22, 2021
71 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
GET /organizationswith authzDELETE /organizations/$org/projects/$project/disks/$disk. I did this one because it exercises the project-level authz in the policy.The next step will be to protect more endpoints using this policy. As it is, the policy file is largely not used, but I thought it was better to do this as a smaller change and then protect more endpoints in follow-on changes.
I'm happy to do a code walk-style review if that's helpful.
Some of this is a little janky right now but I hope we can clean it up as we iterate on more endpoints.