Enable VMM reservoir usage on gimlets#3607
Merged
Merged
Conversation
Contributor
Author
|
I did get a successfully working omicron at least once with this change, and saw that sled agent logged it had provisioned the reservoir. I didn't poke at the system's reservoir live with rsrvrctl, but since I did the testing for the previous PR I'm not worried about that. The type of testing I am more interested in doing on rack2 is provisioning instances, including ones with larger amounts of memory. |
smklein
approved these changes
Jul 13, 2023
auto-merge was automatically disabled
July 14, 2023 16:46
Base branch was modified
Contributor
Author
|
Landing this without the ubuntu build-and-test job passing (it failed due to a timeout), as we've made a call to disable that job for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #3200, sled-agent is capable of provisioning the VMM reservoir on startup. It's configured as a percentage of DRAM via sled-agent's config.toml.
This PR toggles this value to 80% for gimlets. I haven't gotten to test this as much as I had hoped due to unrelated issues with my dev setup. But per the hypervisor huddle today, we would like to enable this in the dogfood cluster as soon as we can, and we want this for FCS. So we decided to land this as is.
Fixes #3223