do not time out database init requests#3503
Conversation
smklein
left a comment
There was a problem hiding this comment.
I'm definitely okay to land this PR as-is, but out of curiosity: Is it expected that setting up CRDB should take so long?
I mean, I've definitely noticed the DB initialization taking a while -- it's what led me to making that "seed DB" optimization like a year ago -- but I dunno, might be worth a peek at some point to make sure CRDB is actually doing useful work during this time, rather than being bottlenecked by something silly.
|
@internet-diglett's machine is relatively slow -- quad-core with spinning disks -- but I don't think that explains all of it. There may well be other room for improvement. I imagine part of the problem is that each SQL statement (i.e., creation of each table and index, of which I think there are now a couple dozen) happen serially, and each probably involves a Raft round-trip plus fsync to stable storage on multiple nodes. 70s still seems like a long time for this though. |
|
Testing note: @internet-diglett and @jordanhendricks were both able to set up Omicron by removing the |
Per Clulow's Lament. See #3498 for details. I also updated the logging as mentioned there.
Fixes #3498.