Use Ipv4Addr instead of String in RackNetworkConfig IP address fields#3399
Merged
Conversation
46b3efc to
2615da2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe based on current usage that all of these are required to be
Ipv4Addrs specifically, and notIpAddr/Ipv6Addr:infra_ip_firstandinfra_ip_lastare stored in a variable namedipv4_block, and a lateripv6_block(that does not use those config values) is also createduplink_ip's doc comment says it should be in theinfra_ip_first..lastrange, which means it would also have to be ipv4gateway_ipwas being parsed intonexthop: Option<Ipv4Addr>.but I don't have a lot of context here so would appreciate confirmation.
Fixes #3397.