[wicket/wicketd] Run RSS from Wicket#3387
Merged
Merged
Conversation
andrewjstone
approved these changes
Jun 21, 2023
andrewjstone
left a comment
Contributor
There was a problem hiding this comment.
Looks awesome. Ship it!
| popup: Option<Popup>, | ||
| } | ||
|
|
||
| impl Default for RackSetupPane { |
Contributor
There was a problem hiding this comment.
Contextual help is so hot these days!
jmpesp
approved these changes
Jun 21, 2023
jmpesp
left a comment
Contributor
There was a problem hiding this comment.
I deployed this in the Canada region and it worked (after setting up the appropriate simulated stuff) - some suggestions though:
- values that are input into
setup set-configshould be rejected earlier. I made it through RSS with values that would not parse asIpAddrand init failed - a similar comment for the uploaded certificates: I got all the way through RSS with certificates that couldn't be used without TLS related errors. the certificates should be validated somehow. for posterity:
jwm@fancyfeast:~$ curl --cacert ~/wicket.ca.pem https://recovery.sys.oxide.test/v1/me
curl: (60) SSL certificate problem: unsupported certificate purpose
More details here: https://curl.se/docs/sslcerts.html
curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
Progenitor doesn't know about alias, so by using rename we can be more consistent with the human-readable speeds (e.g., "40G" over "speed40_g").
This reverts commit 0f12e0d6c54162ddf2bb557a4c34d82f0f21f0e4.
df5e6e4 to
c1d24cc
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk of code in this PR is the new
rack_setupwicket pane, which includes a bunch of popup-related things (which are all fairly verbose for now; I followed what the update pane does structurally, and am very thankful it exists!). On a fresh (uninitialized and unconfigured) system, the pane should look roughly like this, although hopefully not withUNKNOWNbootstrap addresses (those are because these screenshots are from a simulated dev environment that doesn't have a bootstrap network):If we attempt to start an update, we'll get a confirm popup; pressing "Yes" will fail with the error from wicketd (in this case, "you need to configure things!"):
After filling in all the configuration options via the CLI added in #3326, we see the options reflected in the UI:
at which point starting RSS should succeed, and the
Current rack status:line will change toInitializing. This will eventually progress to a new state once RSS completes (whether successful or not).