Skip to content

Clarify the CTE around region allocation#3374

Merged
smklein merged 2 commits into
mainfrom
region-allocate-docs
Jun 18, 2023
Merged

Clarify the CTE around region allocation#3374
smklein merged 2 commits into
mainfrom
region-allocate-docs

Conversation

@smklein

@smklein smklein commented Jun 18, 2023

Copy link
Copy Markdown
Collaborator

Some minor docs improvements, as I dug through this codebase recently:

  • I wanted to clarify, "Does this CTE only provision Crucible datasets to U.2s, and not M.2s?". The answer to this question is: "yes, but implicitly decided when we provision the datasets themselves". Added a comment to clarify this during region selection.
  • Additionally, when referencing a virtual table from an earlier WITH candidate_zpools AS ... arm of the CTE, make that reference explicit. This is a no-op change, but it clarifies the dependencies within the CTE.

@smklein smklein requested a review from bnaecker June 18, 2023 04:58
Comment thread nexus/db-queries/src/db/queries/region_allocation.rs Outdated
@smklein smklein enabled auto-merge (squash) June 18, 2023 17:01
@smklein smklein merged commit 1a43229 into main Jun 18, 2023
@smklein smklein deleted the region-allocate-docs branch June 18, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants