[bootstrap-agent] Split long-running rack-{init,reset} operations#3351
Merged
Conversation
Contributor
Author
|
This PR does not touch the sled-level init / reset operations; if this looks reasonable I can give them the same treatment in a followup PR. |
smklein
approved these changes
Jun 14, 2023
smklein
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for doing this! Agreed that something similar for sled-level init/reset would be useful.
POST'ing or DELETE'ing to `/rack-initialize` now spawns a task to do the work, and a client can `GET /rack-initialize` to check on its status. This also severs the long-running endpoints from cancellation if the client disconnects.
950a1b9 to
cfd2ce7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST'ing or DELETE'ing to
/rack-initializenow spawns a task to do the work, and a client canGET /rack-initializeto check on its status. This also severs the long-running endpoints from cancellation if the client disconnects.