[wicketd] Add periodic check for sled agent bootstrap addrs#3327
Merged
Conversation
andrewjstone
approved these changes
Jun 13, 2023
|
|
||
| let ddm_client = make_ddm_admin_client(&log).await; | ||
|
|
||
| // We only share `sleds` with the `BootstrapPeers` that created us, and it |
| ddm_client: &DdmAdminClient, | ||
| log: &Logger, | ||
| ) -> impl Iterator<Item = Ipv6Addr> { | ||
| // TODO: Should we use `backoff` here instead of a loop/sleep? We're talking |
Contributor
There was a problem hiding this comment.
I don't think we should use a backoff here.
7582ccc to
b2fee2f
Compare
fdda10a to
8a87413
Compare
8a87413 to
2dcd5df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSS wants to know the bootstrap addresses of the sleds to include; this PR teaches wicketd how to find them. It also updates the wicket TOML config introduced in #3326 to include the sled's bootstrap address (if known) in a comment in the sled list; I'm unsure if this is something we'll want to keep once customers are running RSS, but it seems handy for debugging for now.
Builds on #3326.