Conversation
…zones, zone_name -> zone_type, config -> ledger
## Before this PR Running on rack2 and calling `omicron-package uninstall` would involve a fatal termination of the connection, as it would delete the `cxgbe0/ll` and `cxgbe1/ll` IP addresses necessary for contacting the sled. ## After this PR Those addresses are left alone. This is pretty useful for development, as it allows us to run `uninstall` to cleanly wipe a Gimlet, preparing it for future "clean installs".
smklein
commented
May 5, 2023
| /// | ||
| /// If this returns `None`, we have not processed the boot disk yet. | ||
| pub async fn boot_disk(&self) -> Option<DiskIdentity> { | ||
| pub async fn boot_disk(&self) -> Option<(DiskIdentity, ZpoolName)> { |
Collaborator
Author
There was a problem hiding this comment.
A caller could call this function trying to find information about the disk itself (e.g. the ramdisk partition, dump device, etc) or about the zpool.
I return info for both for now, just to satisfy both use-cases. This could be made more structured later.
jgallagher
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most services: Look in the M.2's install directory after looking in "/opt/oxide" when searching for zone images.
Note that propolis images are an exception - we only look for them in the ramdisk.
Fixes #2971