populate Silo DNS names in external DNS#2918
Merged
Merged
Conversation
davepacheco
commented
Apr 24, 2023
| mode = "file" | ||
| path = "/dev/stdout" | ||
| if_exists = "append" | ||
| mode = "stderr-terminal" |
Collaborator
Author
There was a problem hiding this comment.
This change makes this config file consistent with Nexus's example config, which seems useful particularly given that the how-to-run-simulated instructions have you run both of these now, so they should behave the same way in terms of output.
luqmana
reviewed
Apr 24, 2023
luqmana
approved these changes
Apr 25, 2023
69 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change causes Nexus to populate external DNS names for each Silo's console/API endpoint, as determined in RFD 357. This includes some generic infrastructure in the datastore for constructing an update to the DNS configuration, plus a bunch of closely related changes:
omicron-dev run-all, and the "how-to-run-simulated" instructions all start up an external DNS server now.One caveat: this does not generate names for the built-in Silo because that doesn't go through the normal silo-create path. That Silo should be removed by the time we're ready to ship so I didn't think it was worth adding one-off code to support it.