Skip to content

Delete /timeseries/schema#2591

Merged
david-crespo merged 3 commits into
mainfrom
v1-timeseries-schema
Mar 17, 2023
Merged

Delete /timeseries/schema#2591
david-crespo merged 3 commits into
mainfrom
v1-timeseries-schema

Conversation

@david-crespo

@david-crespo david-crespo commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

I don't think anyone is using this, so I'm breaking the rules and converting it straight. See below. Closes #1331.

@david-crespo david-crespo enabled auto-merge (squash) March 17, 2023 17:07
@bnaecker

Copy link
Copy Markdown
Collaborator

I think we may want to nuke this instead. See this issue and this comment thread for more background. I'm not sure we want to expose all the timeseries schema to customers if they have no way of querying them. @ahl that was your comment initially, do you have any more thoughts on it at this point?

@david-crespo

Copy link
Copy Markdown
Contributor Author

I am always happy to delete things outright.

@just-be-dev

Copy link
Copy Markdown
Contributor

I agree, I think we should kill it. We can always reintroduce something similar if we have a product need for it.

@bnaecker

Copy link
Copy Markdown
Collaborator

I'm on board. We can fish it out of the history if needed, and the internal methods for grabbing these from ClickHouse can stick around.

@david-crespo david-crespo changed the title RFD 322: /v1/timeseries/schema Delete /timeseries/schema Mar 17, 2023
# Conflicts:
#	nexus/src/external_api/http_entrypoints.rs
@david-crespo david-crespo merged commit 8f7d3b6 into main Mar 17, 2023
@david-crespo david-crespo deleted the v1-timeseries-schema branch March 17, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Nexus timeseries schema endpoint

3 participants