[nexus] Make disk deletion saga idempotent#2098
Merged
Merged
Conversation
leftwo
approved these changes
Jan 6, 2023
| name: DISK_NAME.parse().expect("Invalid disk name"), | ||
| description: "My disk".to_string(), | ||
| }, | ||
| disk_source: params::DiskSource::Blank { |
Contributor
There was a problem hiding this comment.
This could be expanded to create more DiskSources. There are other code paths that
we don't get coverage on for the saga when we have a Snapshot or a Global Image.
I created an issue for this: #2115
This PR can go ahead without it, as it's improving on what we have now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2094