[nexus] Make disk creation saga idempotent#2097
Merged
Merged
Conversation
13 tasks
leftwo
approved these changes
Jan 6, 2023
leftwo
left a comment
Contributor
There was a problem hiding this comment.
Yeah this looks good.
I guess this means we are, as the title suggests, making it idempotent.
I go back and forth about if it is an error when you try to create anything
and what you are trying to create is already there. I think in this case
it won't be a problem, so yeah, good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2094