Skip to content

[nexus] Make snapshot deletion a saga#2090

Merged
smklein merged 27 commits into
mainfrom
snapshot-delete-saga
Dec 28, 2022
Merged

[nexus] Make snapshot deletion a saga#2090
smklein merged 27 commits into
mainfrom
snapshot-delete-saga

Conversation

@smklein

@smklein smklein commented Dec 22, 2022

Copy link
Copy Markdown
Collaborator

Part of #2059

Comment thread nexus/src/app/sagas/snapshot_delete.rs Outdated

@leftwo leftwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Just a question really about if a comment is still relevant.

Comment thread nexus/src/app/disk.rs
Base automatically changed from project-creation-saga-idempotent to main December 28, 2022 20:00
@smklein smklein enabled auto-merge (squash) December 28, 2022 20:03
@smklein smklein merged commit 6970a85 into main Dec 28, 2022
@smklein smklein deleted the snapshot-delete-saga branch December 28, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants