faux-mgs: Move majority of implementation into gateway-sp-comms#1579
Merged
Conversation
andrewjstone
approved these changes
Aug 16, 2022
andrewjstone
left a comment
Contributor
There was a problem hiding this comment.
Looks really good. Mostly nits from me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of two PRs that work toward a cleanup of MGS's implementation and making it share the bulk of its implementation with
faux-mgs. In this PR, we add aSingleSptogateway-sp-commsand reworkfaux-mgsto use it.SingleSpis a handle to a tokio task that owns a singleUdpSocketused to talk to a single SP (and in the full MGS sense, is conceptually the socket associated with one port of the management network switch).The next PR will rework MGS proper to make use of
SingleSp; in this PR, it is only used byfaux-mgs.