test write access by unprivileged users to read-only resources#1399
Merged
Conversation
Collaborator
Author
|
On commit cbf1b8d, here's the output of the unauthorized test: Note that we're skipping testing the authenticated, unauthorized user for all methods for endpoints like |
davepacheco
commented
Jul 13, 2022
| # | ||
| # It's unclear what else would break if users couldn't see their own Silo. | ||
| has_permission(actor: AuthenticatedActor, "read", silo: Silo) | ||
| # TODO actor.silo is *not* a list, so `in` is incorrect here, but if you |
Collaborator
Author
There was a problem hiding this comment.
I removed this comment and the one at L171 because this behavior is documented:
https://docs.osohq.com/rust/reference/polar/classes.html#options
What wasn't obvious to me from the documentation was whether x in y returns true if y was any Some value or only if it was Some(x). I've tested it, and it's only if y is Some(x) (which of course makes much more sense).
Contributor
There was a problem hiding this comment.
Thanks, was not aware of that language feature. Makes sense, though still a bit non-obvious (to me, at least).
plotnick
approved these changes
Jul 13, 2022
plotnick
left a comment
Contributor
There was a problem hiding this comment.
Thanks as always for helping to ensure that authorization is working correctly and as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1341 I suggested that the "unauthorized.rs" test could test the behavior of unprivileged users attempting to POST/PUT/DELETE things they're only supposed to be able to read. I'm trying that here.