Conversation
This commit makes the final step in plumbing metrics genrated in Crucible Upstairs through Propolis to Oximeter. Updated versions of both Crucible and Propolis are required (and they both require this update). Removed two fields of CrucibleOpts that are obsolete. Updates to supply a UUID to the VolumeConstructionRequest. It is currently just a random UUID, but that is how it was on the crucible side already, and this change will allow Nexus, when it is ready, to supply a real UUID. This change is not required for the metrics, but the change is already in the Crucible side, so it must be included when we update the Crucible rev. New git rev and packages for both Propolis and Crucible
Contributor
Author
|
@smklein I'd love your thoughts on how best to get the Nexus IP:Port into the |
Collaborator
Sorry for the delay on this. Let me pull the DNS utilities out of some of my larger patchsets, so they can be used by the sled agent. |
Collaborator
|
Done in #1386 |
Contributor
Author
|
Updated the sled-agent instance code to get the I.P. for Nexus from Crucible and Propolis changes are all back, and the package-manifest has been updated, so this is ready for |
smklein
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the final step in plumbing metrics generated in
Crucible Upstairs through Propolis to Oximeter. Updated versions
of both Crucible and Propolis are required (and they both require
this update).
Removed two fields in
CrucibleOptsthat are now obsolete.Some updates to supply a UUID to the
VolumeConstructionRequest.It is currently just a random UUID, but that is how it was on the
crucible side already, and this change will allow Nexus, when it is
ready, to supply a real UUID. This change is not required for the
metrics, but the change is already in the Crucible side, so it
must be included when we update the Crucible rev.
New git rev and packages for both Propolis and Crucible
I'm not sure how to get the IP:Port for nexus down into the
sled-agent
setup_propolis_locked()method. I was thinking eitherattach it to
InstanceInneras a field, or add a method toNexusClientthat would return the IP:Port for thatNexusClient.Neither way seems ideal. I'm open to other ideas.
Things that should happen before this goes in: