Skip to content

test proving that duplicate roles in PUT body trigger 500#1184

Closed
david-crespo wants to merge 1 commit into
mainfrom
duplicate-role-assignment-500
Closed

test proving that duplicate roles in PUT body trigger 500#1184
david-crespo wants to merge 1 commit into
mainfrom
duplicate-role-assignment-500

Conversation

@david-crespo

@david-crespo david-crespo commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@david-crespo david-crespo mentioned this pull request Jun 9, 2022
Open
@david-crespo

david-crespo commented Jun 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author 
test integration_tests::role_assignments::test_role_assignments_fleet ... FAILED
test integration_tests::role_assignments::test_role_assignments_organization ... ok
test integration_tests::role_assignments::test_role_assignments_project ... ok
test integration_tests::role_assignments::test_role_assignments_silo ... ok

Amusingly, fleet alone does not have this problem. Fleet probably has this problem too, but something strange is going on. It 500s on the added dupes request as expected, but then the subsequent GET seems to be 403ing. So it seems something exciting is happening before that 500.

omicron/nexus/tests/integration_tests/role_assignments.rs

Line 484 in 2fccebe

let current_policy = policy_fetch::<T::RoleType>(client, &policy_url).await;

@davepacheco

davepacheco commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

Fleet probably has this problem too, but something strange is going on. It 500s on the added dupes request as expected, but then the subsequent GET seems to be 403ing. So it seems something exciting is happening before that 500.

Was it a 403 before the policy change as well?

@david-crespo

david-crespo commented Jun 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I don't think it could be, because the test passes without my added PUT with dupes.

@david-crespo

david-crespo commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Closing because this doesn't need to be open to serve its purpose!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@david-crespo @davepacheco