spoof authn should look up the user's silo#1090
Merged
Merged
Conversation
69 tasks
| | Error::Forbidden | ||
| | Error::InternalError { .. } | ||
| | Error::ServiceUnavailable { .. } | ||
| | Error::MethodNotAllowed { .. } => { |
Contributor
There was a problem hiding this comment.
I assume you're not using a catch-all here to make sure any new cases are handled explicitly?
david-crespo
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #1087 I noticed that the spoof authn mechanism always assumes that the specified Silo User exists and is in the default Silo. It should instead look up the given Silo User and use their real Silo id. This will become important when we have tests that create multiple Silos with users in each Silo. Without this change, such tests would fail in confusing ways because even though a user was created in Silo B, we'd be treating them as though they were in Silo A.
This is still "draft" because it depends on #1087. (It's also not tested yet.)