Skip to content

Generated client for ExternalIpCreate feels clunky #1501

@iliana

Description

@iliana

image
image

type_ is awkward here. What I would expect is to be able to write something like ExternalIpCreate::Ephemeral { pool_name: None }; is the pool name relevant for all future kinds of external IP creation objects?

If we want to leave the shape the same I would recommend renaming type to kind.

cc @bnaecker

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions