Pretty print unified diff with 5 line before/after window#10
Merged
Conversation
191de7f to
bfe4f0c
Compare
david-crespo
commented
Mar 18, 2022
| Changeset::new(expected.as_ref(), actual.as_ref(), "\n"); | ||
| println!("{}", changeset); | ||
| let diff = | ||
| unified_diff(Algorithm::Myers, &expected, &actual, 5, None); |
Contributor
Author
There was a problem hiding this comment.
Myers is the default algorithm in git, so that seems fine. 5 is the number of lines before and after. None could be replaced with a header representing the two file names, not sure if we care.
Collaborator
There was a problem hiding this comment.
Yeah there's only one file and it should be clear from context so agreed that it's not useful to add a header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
Tried and failed to make it work with
differenceandpretty_assertions. Found success with Similar. Very clean.This is already a net improvement as-is, but some possible improvements:
one line difference
all lines difference