do our best to emit macro output even in the face of errors#135
Merged
Conversation
Collaborator
|
Thanks, Adam! I will test this tomorrow (Tuesday). |
this turns out to be important in order to not confuse rust-analyzer
Collaborator
Author
No rush. I'm not 100% about this approach; it may well be the wrong direction. |
davepacheco
reviewed
Oct 12, 2021
davepacheco
left a comment
Collaborator
There was a problem hiding this comment.
The error message diffs look fine to me. Thanks for doing this.
Collaborator
|
After tinkering with it for a while, I have not been able to confuse RA in the way it could become confused before. This is obviously not a precise test, but it so far feels a lot less flaky to me. Thanks for doing this! |
Collaborator
Author
|
Awesome! Thanks for taking it for a spin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #134
This restructures the
#[endpoint .. ]macro so that it only fails in the case of some really busted input. Our goal is to do our level best to produce reasonable output in order to avoid confusing rust analyzer.Note that this changed some of the error messages; I think these are largely improvements, but @davepacheco I'd love your opinion.
@jclulow if you're able to see if this resolves your issue that would be tremendously helpful. I played around on the latest RA, and while I was able to conjure up what you described, I'm not 100% convinced that this fixes it (i.e. and that perhaps I'm now just getting lucky).